linkedin / linkedin/oncall

Javascript error: Moment Timezone has no data for Europe/Amsterdam

Open
#132 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.3k
Forks
245
PR merge metrics
No merged PRs in 30d

Description

It seems that a minimal version of timezone data is included (js/moment-tz-data.js) rather than the full version js/moment-tz-data-full.js.

This results in an error when using timezones outset of the smaller subset. Not sure how to proceed. It's rather unfriendly to ask users to patch the timezone data. But I can imagine including the full dataset is rather heavy (175kb vs 9kb).

That said, perhaps this is just unavoidable when gaining wider exposure.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing js/moment-tz-data.js with js/moment-tz-data-full.js and reproduce the Europe/Amsterdam failure. Determine the supported timezone-data strategy, including its size trade-off, and verify that the chosen approach handles timezones outside the minimal subset without requiring users to patch data.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.