linkedin / linkedin/luminol

error in diff_percent_threshold.py

Open
#58 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.2k
Forks
217
PR merge metrics
No merged PRs in 30d

Description

the code in enumerater should be baseline_value = self.baseline_time_series[timestamp] instead of baseline_value = self.baseline_time_series[i].
otherwise it will give "timestamp does not exist in time series object" exception.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open diff_percent_threshold.py and inspect the enumerater code around the baseline_value assignment. Verify that the timestamp-based lookup is used instead of the index-based lookup, then reproduce the reported case to confirm the "timestamp does not exist in time series object" exception is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.