incorrect normalize method
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 217
- PR merge metrics
- No merged PRs in 30d
Description
Unless there is a specific reason for only using the max value to normalize the values with, the normalize function could do with being normalized or renamed if the current ```normalize``` method is the desired method of "normalization" as it is not what is generally accepted as normalizing, just using the max that is.
Although this normalize method **does** return all the values between 0 and 1, for **a positive values set**, it does not normalize the data if there are negative values in the set, this could skew correlations and seeing as the average is being applied, arguably normalize is being incorrectly calculated.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue identifies the normalize method as the entry point, but does not name a file or test. First establish the intended normalization semantics for negative values and their effect on correlations; done requires agreed behavior and coverage for the relevant value sets.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100