Passed max_shift_seconds in CrossCorrelator not coverted to milliseconds
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 217
- PR merge metrics
- No merged PRs in 30d
Description
In src/luminol/algorithms/correlator_algorithms/cross_correlator.py if max_shift_seconds is passed, it is not converted to milliseconds like the DEFAULT_ALLOWED_SHIFT_SECONDS
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/luminol/algorithms/correlator_algorithms/cross_correlator.py and compare the handling of an explicit max_shift_seconds value with DEFAULT_ALLOWED_SHIFT_SECONDS. Verify that the supplied value uses the same seconds-to-milliseconds conversion, then run the relevant project tests or a focused CrossCorrelator check to confirm the resulting shift is correct.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100