percentile threshold not working
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.2k
- Forks
- 217
- PR merge metrics
- No merged PRs in 30d
Description
Looks like `self.threshold` is assigned already in constructor. The percentile part needs rework into if-else or rework.
As it is now, threshold based on percentile is never assigned and instead default threshold value is used (or if specified by parameter `score_threshold`
https://github.com/linkedin/luminol/blob/master/src/luminol/anomaly_detector.py#L115
https://github.com/linkedin/luminol/blob/master/src/luminol/anomaly_detector.py#L53
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/luminol/anomaly_detector.py at the constructor and the referenced lines around 53 and 115. Trace how self.threshold is assigned for percentile and score_threshold inputs; the issue is done when percentile-based threshold selection is used instead of the default threshold.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100