Error running "make targets"
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 845
- Forks
- 146
- PR merge metrics
- No merged PRs in 30d
Description
I am getting below error while running make targets on iris.
File "/iris/src/iris/bin/sync_targets.py", line 145, in
if user['active']}
TypeError: string indices must be integers
Makefile:13: recipe for target 'targets' failed
make: *** [targets] Error 1
Below are the logs from oncall server.
[10/Jan/2019:04:24:05 +0000] "GET /api/v0/users?fields=name&fields=contacts&fields=active HTTP/1.1" 401 85 "-" "python-requests/2.20.0"
Originally posted by @adityavijjanT in https://github.com/linkedin/iris/pull/333#issuecomment-452990413
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with iris/bin/sync_targets.py at line 145 and the targets recipe in Makefile:13, then compare the expected users response with the logged 401 request. Reproduce make targets and determine why the response is indexed as user records; done means the command completes without the TypeError and the users request is handled successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100