linkedin / linkedin/icon-magic

`mixed` flavor is not passed down to other generate plugins by default

Open
#336 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
18
Forks
1
PR merge metrics
No merged PRs in 30d

Description

After pairing with @ramitha today, we realized that the mixed flavor is not passed down to svg-to-custom-element generate plugin unless we use '-nc, --noCache' cli option. Expected behavior is that when we build & generate icons, the ones with the mixed flavor should also be passed down as input to the other generate plugins in queue (e.g., svg-to-custom-element and svg-to-raster) by default, i.e, without bursting the cache.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace how the mixed flavor is handled when icons are built and passed through the generate-plugin queue, comparing the default path with the -nc/--noCache path. Check the svg-to-custom-element and svg-to-raster plugin inputs; done when mixed-flavor icons reach those plugins by default without disabling the cache.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.