linkedin / linkedin/icon-magic

createAsHbs should be moved into its own generate plugin

Open
#326 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
18
Forks
1
PR merge metrics
No merged PRs in 30d

Description

This will take two config params (currently these are coming from different places, need to move them out)
pathToTheImageAsset
imageHrefHelper

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate createAsHbs and trace where pathToTheImageAsset and imageHrefHelper are currently configured. Determine the generate-plugin entry point and move createAsHbs into its own plugin with those two configuration parameters; the work is done when the existing icon-generation flow uses the new plugin.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.