linkedin / linkedin/icon-magic
Cashing is not changing `/out` when making changes to `iconrc.json` and running `yarn icon-magic` a second time.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 18
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
I edited an `iconrc.json` file and ran `yarn icon-magic `. That made the expected changes to the `/out/`. But I had made a mistake in the `iconrc.json` file. When I made the minor edit and ran `yarn icon-magic ` again, the changes were no longer reflected in the `/out/`.
That lead me to explore and conclude that cashing must not be allowing the update. I erased the `/out/` and ran `yarn icon-magic` again. The correct changes were reflected. in the `/out/`
Maybe look at cashing logic for minor edits when part of icon does exist in the /out directory already.
Thank you
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running `yarn icon-magic ` with an existing `/out/` and a minor `iconrc.json` edit. Inspect the caching logic for how existing output is reused, then verify that a second run reflects the edited configuration without deleting the output directory.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100