linkedin / linkedin/icon-magic

running icon magic fails if the folder passed in doesn't have an iconrc

Open
#181 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
18
Forks
1
PR merge metrics
No merged PRs in 30d

Description

when running icon-magic command on a specific folder that doesn't have an iconrc file, the command will fail because it does not look up the tree for any ancestor to have an iconrc file

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the icon-magic command and its iconrc lookup behavior. Reproduce the failure by running the command on a folder without an iconrc while an ancestor has one; done means the ancestor configuration is found and the command succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
build-system, cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.