linkedin / linkedin/icon-magic
iconrc files change when the icons don't
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 18
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
Hashing works on the icons and they don't get regenerated if the source icon hasn't changed. But the .iconrc files get rewritten, as the order of the icons change. This ticket is to leave the .iconrc unchanged if the sources don't change.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the .iconrc generation path and the hashing logic described in the issue. Confirm how icon ordering causes a rewrite when source icons are unchanged; done means unchanged sources leave the existing .iconrc files untouched while changed sources still update them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100