linkedin / linkedin/greykite

Can we upgrade holiday library version

Open
#145 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.9k
Forks
107
PR merge metrics
No merged PRs in 30d

Description

Currently greykite uses an older version of holiday which conflicts with newer version of prophet.
A known issue in older version of prophet causing this issue https://github.com/facebook/prophet/issues/2462.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Greykite's dependency declarations and identify the pinned holiday version and its relationship to the Prophet dependency. Check the linked Prophet issue for the compatibility context, then verify the upgraded dependency resolves the conflict without breaking the project's existing checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.