linkedin / linkedin/greykite

MultistageForecastTemplate does not work

Open
#144 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.9k
Forks
107
PR merge metrics
No merged PRs in 30d

Description

Updated to the latest version of greykite 1.1.0 and encountered an error when using the **SILVERKITE_TWO_STAGE** model template.

[MultistageForecastTemplate line 65](https://github.com/linkedin/greykite/blob/master/greykite/framework/templates/multistage_forecast_template.py#L65) - `AttributeError: can't set attribute 'constants'`. You have @property def constants, but you don't have @constants.setter — it does self.constants = ... a prohibited action.

[MultistageForecastTemplate line 69](https://github.com/linkedin/greykite/blob/master/greykite/framework/templates/multistage_forecast_template.py#L69) - constants() — you call it as a function, but constants is an instance (not a callable object). This will cause a `TypeError: 'MultistageForecastTemplateConstants' object is not callable`.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect greykite/framework/templates/multistage_forecast_template.py at lines 65 and 69, starting with how MultistageForecastTemplate defines and uses constants. Exercise the SILVERKITE_TWO_STAGE model template and confirm that initialization no longer raises the reported AttributeError or TypeError.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.