linkedin / linkedin/greykite

Greykite design question

Open
#125 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.9k
Forks
107
PR merge metrics
No merged PRs in 30d

Description

I wanted to bring up a question regarding the software architecture rather than a specific issue.

While exploring the Greykite source code, I noticed that the final step of the pipeline involves a SilverkiteEstimator object, which wraps SilverkiteForecast. It seems like SilverkiteForecast handles various tasks related to feature transformation and preprocessing, such as Fourier seasonalities, changepoint detection, and time-related feature extraction.

I was wondering if it would be more logical to have each of these steps as separate transformers in the pipeline, instead of consolidating them all in the last step. This approach would not only facilitate the use of Greykite as a feature extractor (by stopping the pipeline before the actual ML step), but also enable the utilization of virtually any sklearn-compatible regressor.

I understand that implementing this change would require significant effort, but I wanted to inquire whether other users share a similar sentiment or if I might be overlooking something.

Once again, I appreciate the great work you've done!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading greykite/sklearn/estimator/silverkite_estimator.py and greykite/algo/forecast/silverkite/forecast_silverkite.py, focusing on how preprocessing and forecasting steps are combined. Determine whether those steps can be separated into sklearn-compatible transformers and what interfaces would be needed to support feature extraction and alternate regressors; done would require an agreed design and scope.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, scikit-learn
Domain
machine-learning
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.