linkedin / linkedin/goavro

Arrays and nullable arrays don't decode into the same types

Open
#90 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement help wanted
Dominant language
Go
Stars
1.1k
Forks
232
PR merge metrics
No merged PRs in 30d

Description

https://github.com/kklipsch/goavro.v2/blob/slice/record_test.go#L472-L519

Coming out of the nullable code you get the type you put in (in our test case []int32) coming out of the non-nullable code you get []interface{}.

This seems bad.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with record_test.go lines 472-519, linked in the issue, and run the array and nullable-array decoding tests. Compare the decoded types for both paths; done means arrays and nullable arrays decode into the same corresponding Go type.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.