Question: Reg. Parameter type of OCFWriter Append function
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.1k
- Forks
- 232
- PR merge metrics
- No merged PRs in 30d
Description
## Context
I see the OCF Writer append function has the signature
```go
func (ocfw *OCFWriter) Append(data interface{}) error
```
Inside this we are having a reflection based code to ensure this is of a slice type
https://github.com/linkedin/goavro/blob/9f4e906150da20936a04d07bc0bc4d3f7c28bf56/array.go#L213
## Curious Question
Why not change the parameter type to `[]interface{}` ?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with OCFWriter.Append in array.go at the linked implementation and review how its parameter is validated. Determine whether changing the parameter to []interface{} would preserve the supported inputs and API behavior; done means documenting the rationale or defining the required API change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- data
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100