linkedin / linkedin/goavro

parsingCanonicalForm() doesn't handle logicalTypes properly

Open
#174 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
1.1k
Forks
232
PR merge metrics
No merged PRs in 30d

Description

The function to create schema canonical form cannot handle logicalTypes properly. An example of such schema is `{"type":"long","logicalType":"timestamp-millis"}` and canonical form should be just `"long"`.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate parsingCanonicalForm() in the Goavro source and start by tracing how it processes the schema object in the reported example. Add or update a focused test for {"type":"long","logicalType":"timestamp-millis"}; done means its canonical form is "long".

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.