`CanonicalSchema` and `SchemaCRC64Avro` fail to inline sub-schemas referenced by name
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 1.1k
- Forks
- 232
- PR merge metrics
- No merged PRs in 30d
Description
If the type of a record field, array, or map-value refers to a previously-declared type by name (eg, `"type": "com.example.MyEmbeddedType"`), then the structure used to compute the `schemaCanonical` string (and thus the schema fingerprint) should embed the fully-specified sub-schema, rather than just the type name.
The current implementation fails to dereference the named schema, resulting in incorrect canonicalization and fingerprinting.
I can follow up later with a concrete example, and I'm working on a fix which I will hopefully submit for review soon.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the CanonicalSchema and SchemaCRC64Avro entry points, then trace named-type handling for record fields, array items, and map values. Done means schemaCanonical embeds each fully specified referenced sub-schema and SchemaCRC64Avro produces the corresponding fingerprint for these cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100