File ignored by eyeglass installer gets installed after restart.
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 738
- Forks
- 48
- PR merge metrics
- No merged PRs in 30d
Description
Package
This issue is related to the following monorepo package(s):
- eyeglass
- broccoli-eyeglass
- ember-cli-eyeglass
Description
There's a weird issue in a LinkedIn project where a file that isn't installed gets installed anyway.
let ignoredExtensions = new Set(['js', 'css']);
eyeglass.assets.installer(function myInstaller(
assetFile,
assetUri,
oldInstaller,
cb
) {
const assetExtension = assetUri.split('.').pop();
if (
ignoredExtensions.has(assetExtension)
) {
cb(null, assetFile);
} else {
oldInstaller(assetFile, assetUri, cb);
}
});
Returning null should cause the asset to not be installed, but they are seeing that it is found after restarting the server.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the ember-cli-eyeglass asset installer and trace how the installer callback result is handled across a server restart. Reproduce the ignored-extension case from the issue, then verify that an asset returned as null is not discovered or installed after restarting the server.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, sass
- Domain
- build-system, tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100