linkedin / linkedin/eyeglass

eyeglass-exports: segmentation fault / abort trap

Open
#194 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

package:eyeglass
Dominant language
TypeScript
Stars
738
Forks
48
PR merge metrics
No merged PRs in 30d

Description

I read through #69 and #74, which seem to be the closest to this, but I don't think are the same.

My setup

```js
// @fastly/fui-color/package.json
"eyeglass": {
"exports": "lib/eyeglass-exports",
"sassDir": ".",
"needs": "*"
},

// @fastly/fui-color/lib/eyeglass-exports.js
module.exports = function(eyeglass, sass) {
return {
functions: {
'fastly-color($name)': function($name, done) {
done(sass.types.String('#abcdef'))
}
},
}
}
```
I'm including that in an ember app with
```
node@10.13.0
broccoli-eyeglass@4.4.4
ember-cli@3.1.3
ember-cli-eyeglass@5.0.1
eyeglass@1.6.0
node-sass@3.13.1
```

When I run `ember build`, it fails with
```
Assertion failed: (!persistent().IsWeak()), function Unref, file ../../../../nan/nan_object_wrap.h, line 107.
Abort trap: 6
```

If I upgrade to node-sass@4.10.0, it instead fails with
```
libc++abi.dylib: terminating with uncaught exception of type std::length_error: vector
Abort trap: 6
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure from lib/eyeglass-exports.js with the listed Node, broccoli-eyeglass, Ember CLI, eyeglass, and node-sass versions, then compare the ember build errors for node-sass 3.13.1 and 4.10.0. Done means the eyeglass export builds without a segmentation fault or abort trap, with the relevant compatibility cause documented or covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
build-system, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.