linkedin / linkedin/eyeglass

provide simpler relative url option

Open
#115 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement package:eyeglass
Dominant language
TypeScript
Stars
738
Forks
48
PR merge metrics
No merged PRs in 30d

Description

`options.eyeglass.assets.relativeTo` works but only if you don't have to specify a static set of options. We should allow relativeTo to be a function for the general case and provide a simpler option where url generation that assumes css location and asset locations on disk are the public URL structures.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of options.eyeglass.assets.relativeTo and the URL-generation entry point. Determine how a function-valued relativeTo and the simpler CSS-and-asset-location option should behave, then confirm both cases with the project's existing tests. Done means both requested forms are supported without requiring a static option set.

Written by the indexing model from the issue text.

Assessment

Tech stack
sass, typescript
Domain
web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.