linkedin / linkedin/dynamometer
Option parsing bug for start-component.sh
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 134
- Forks
- 34
- PR merge metrics
- No merged PRs in 30d
Description
This might be related with #52 .
In https://github.com/linkedin/dynamometer/blob/master/dynamometer-infra/src/main/java/com/linkedin/dynamometer/Client.java#L327 it is trying to find whether there is help option entered for the function, but internally it is using a GnuParser (which is deprecated from version 1.3), and during the flatten process it will try to pull the substring of -h from option -hadoop_binary_path and thinks it is asking for help information.
Note this only happens when you put the -hadoop_binary_path as the first option since other options will make the flatten end early.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at dynamometer-infra/src/main/java/com/linkedin/dynamometer/Client.java#L327 and inspect how start-component.sh options are parsed, especially the help check and flattening behavior. Reproduce the case with -hadoop_binary_path as the first option, then verify that it is not treated as help while genuine help input still behaves correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100