Compilation failing tests using ./compile.sh

Open

#571 opened on May 15, 2019 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language: Java
Stars: 1.4k
Forks: 839
PR merge metrics: No merged PRs in 30d

Description

It does not work:

**1/6 TEST ERRORS:**

[error] Test com.linkedin.drelephant.tuning.PSOParamGeneratorTest.getParamsTest failed: Swarm size did not match expected:<3> but was:<0>
[error] Test com.linkedin.drelephant.tuning.PSOParamGeneratorTest.generateParamSetTest failed: java.lang.RuntimeException: java.lang.NullPointerException
[error] at play.libs.Json.parse(Json.java:71)
[error] at com.linkedin.drelephant.tuning.PSOParamGeneratorTest$2.run(PSOParamGeneratorTest.java:119)
[error] at play.test.Helpers.running(Helpers.java:417)
[error] at com.linkedin.drelephant.tuning.PSOParamGeneratorTest.generateParamSetTest(PSOParamGeneratorTest.java:86)
[error] ...
[error] Caused by: java.lang.NullPointerException
[error] at com.fasterxml.jackson.core.JsonFactory.createParser(JsonFactory.java:822)
[error] at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:2580)
[error] at play.libs.Json.parse(Json.java:69)
[error] ... 40 more

**Finally compilation generates:**

[info] Run completed in 28 seconds, 638 milliseconds.
[info] Total number of tests run: 150
[info] Suites: completed 15, aborted 0
[info] Tests: succeeded 144, failed 6, canceled 0, ignored 0, pending 0
[info] *** 6 TESTS FAILED ***
[error] Failed: Total 483, Failed 8, Errors 0, Passed 474, Skipped 1
[error] Failed tests:
[error] com.linkedin.drelephant.tuning.PSOParamGeneratorTest
[error] com.linkedin.drelephant.util.SparkUtilsTest
[error] (test:test) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 44 s, completed May 15, 2019 12:52:33 PM
Build failed...

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with ./compile.sh, then inspect com.linkedin.drelephant.tuning.PSOParamGeneratorTest, especially the references at lines 86 and 119, along with com.linkedin.drelephant.util.SparkUtilsTest. Trace why the expected test inputs produce the reported swarm-size and JSON errors; done means the compilation completes with all tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack: java, spark
Domain: build-system, testing-qa
Issue type: Bug
Difficulty: 4/5
Estimated time: 3-5 days
Activity status: Stale
Clarity: Needs clarification
Newbie friendliness: 25/100