linkedin / linkedin/dexmaker

Don't rethrow the targetException of InvocationTargetException when calling the ProxyBuilder$callSuper

Open
#203 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
2k
Forks
262
PR merge metrics
No merged PRs in 30d

Description

https://github.com/linkedin/dexmaker/blob/1e70acec40569d613b88f1336944040f01202e73/dexmaker/src/main/java/com/android/dx/stock/ProxyBuilder.java#L666-L668

The InvocationTargetException type is useful to locate the source of the target method exception, I think it should be retained.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read dexmaker/src/main/java/com/android/dx/stock/ProxyBuilder.java around lines 666-668 and trace ProxyBuilder$callSuper's handling of InvocationTargetException. Confirm the intended behavior for exceptions from the target method, then verify that the resulting exception retains its InvocationTargetException wrapper.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
mobile
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.