linkedin / linkedin/datahub-gma
Sync get, getAll, batchGet, and search getInternal behavior
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 142
- Forks
- 63
- Avg merge
- 3d 10h
- Merged PRs (30d)
- 4
Description
Is your feature request related to a problem? Please describe.
PR#132 changes the intended behavior of get() when parameter aspectNames is empty. Instead of throwing a 404, it will return VALUE with no aspects. To accomplish this behavior, getInternalNonEmpty call was changed to getInternal. We need to evaluate this behavior with getAll(), batchGet(), and search() methods to make sure they are aligned with get()'s new behavior.
Describe the solution you'd like
Double check and update calls to getInternalNonEmpty if needed to match with new get() behavior.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect get(), getAll(), batchGet(), and search(), then find their calls to getInternalNonEmpty. Compare them with the behavior introduced by PR #132 and update any inconsistent calls; the work is done when all methods handle empty aspectNames consistently with get().
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend-api-design
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100