linkedin / linkedin/css-blocks

`@block` imports are too sensitive about missing semicolons

Open
#236 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
6.3k
Forks
154
PR merge metrics
No merged PRs in 30d

Description

## Expected
Semicolons should be optional at the end of `@block` import lines. Ex:

## Actual
Throws a confusing lookup path error because the parser does not consider `\n` to be a terminating char. Following lines are accidentally considered part of the file path.

Contributor guide

Open the contributing guide

Research direction

Locate the parser handling `@block` import lines and reproduce an import without a trailing semicolon. Check how newline characters terminate the file path, then add coverage for the semicolon-optional form and confirm that following lines are no longer included in lookup errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, typescript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.