linkedin / linkedin/coral

Implicit call order assumption in SqlCallTransformer.getRelDataType(SqlNode)

Open
#347 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

CoralIR
Dominant language
Java
Stars
906
Forks
219
Avg merge
2d 13h
Merged PRs (30d)
2

Description

Current SqlCallTransformer.getRelDataType(SqlNode) assumes that the parent SqlSelect is visited before determining the datatype of the child SqlNode, which is typically achieved by traversing the SqlNode tree using SqlShuttle. Ideally, its implementation should be updated to not rely on this assumption for determining the datatype of the child SqlNode.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in coral-common/src/main/java/com/linkedin/coral/common/transformers/SqlCallTransformer.java at getRelDataType(SqlNode), then trace how SqlShuttle traversal establishes the parent SqlSelect state before child datatype resolution. The work is complete when child datatype determination no longer depends on that traversal order and the existing transformation behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.