linkedin / linkedin/avro-util

Utils.inferCompileDependencies does not create a valid classpath on windows

Open
#386 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
87
Forks
73
Avg merge
2h 50m
Merged PRs (30d)
1

Description

com.linkedin.avro.fastserde.Utils.inferCompileDependencies(String, String, Set) should be using ";" as a separator instead of ":" on windows when creating a classpath.

I think the correct field to use is: java.io.File.pathSeparatorChar / java.io.File.pathSeparator

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at com.linkedin.avro.fastserde.Utils.inferCompileDependencies(String, String, Set) and inspect how it assembles the classpath. Verify that the separator comes from java.io.File.pathSeparator or pathSeparatorChar and confirm that the resulting classpath uses the Windows separator when run on Windows.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
build-system
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.