getNullableGenericDefaultValue API should fail Map type with null as default value.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 87
- Forks
- 73
- Avg merge
- 2h 50m
- Merged PRs (30d)
- 1
Description
Currently getNullableGenericDefaultValue return a hashmap object for Map type with null as default value. For example:
{
"name": "fieldName",
"type": {"type":"map", "values":"string" },
"doc" : "test.",
"default" : null
}
For this field, the getNullableGenericDefaultValue api returns a HashMap object which shouldn't.
https://github.com/linkedin/avro-util/blob/b6769c3dbbe768148b8dbcfb16affccd7f2ad578/helper/helper-common/src/main/java/com/linkedin/avroutil1/compatibility/SchemaValidator.java#L157
in this place it should also validate if the defaultValue as Map object is empty or not
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in helper/helper-common/src/main/java/com/linkedin/avroutil1/compatibility/SchemaValidator.java around line 157 and inspect getNullableGenericDefaultValue for map defaults. Reproduce the schema example from the issue, then verify that a map with a null default is rejected rather than returning a HashMap; the payload does not name a test file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100