linkedin / linkedin/avro-util

validate output of SpecificData.get().getDefaultValue(field) in getSpecificDefaultValue()

Open
#244 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement helper
Dominant language
Java
Stars
87
Forks
73
Avg merge
2h 50m
Merged PRs (30d)
1

Description

scenario:

there's an enum class on the classpath of the same FQCN as an avro enum, but not generated by avro.
avro (at least under 1.9) will return an instance of this non-avro enum out of:

  @Override
  public Object getSpecificDefaultValue(Schema.Field field) {
    return SpecificData.get().getDefaultValue(field);
  }

we could at least validate that the enum instance belongs to a class thats generated by avro, and save users some pain downstream

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at getSpecificDefaultValue() and inspect its call to SpecificData.get().getDefaultValue(field). Reproduce the classpath case where a same-FQCN non-Avro enum is returned, then define validation that rejects or handles that value; done means the invalid enum cannot pass downstream.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.