linkedin / linkedin/avro-util

[helper] Maybe refactor the naming of Avro version-specific impl and tests.

Open
#213 0 comments 0 reactions 1 assignee View on GitHub

@srramach is already working on this.

Since Oct 2, 2021.

enhancement helper
Dominant language
Java
Stars
87
Forks
73
Avg merge
2h 50m
Merged PRs (30d)
1

Description

Today, Avro version-specific impl and tests are specific to a minor version; the naming for them squashes the major and minor parts of the version together. So we have `foo14bar` for 1.4.\*, `foo110bar` for 1.10.\* and so on.

We might need to add patch-specific impl and tests. E.g., 1.7.2 versus 1.7.7. At that point, the squashing doesn't work so well and can be mildly confusing.

It would be better to separate out the version parts with underscores, as is already done in the fastserde module. So, foo_1_4_bar, foo_1_7_2_bar, etc.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.