linkedin / linkedin/ambry

RestRequest shoud have getHeaders(), getQueryParams() interfaces instead of getArgs()

Open
#996 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.8k
Forks
298
Avg merge
21h 43m
Merged PRs (30d)
9

Description

HTTP headers are quite different from query parameters, it seems incorrect to mix them in getArgs(). For example, if-modified-since in HTTP Header has its own meaning, but an if-modified-since query parameter has not.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating RestRequest, its getArgs() implementation, and the callers that consume its values. Trace how headers and query parameters are currently represented, then review related tests or API documentation to define separate interfaces and verify that existing request behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.