linkedin / linkedin/ambry

Do not return hardDeleted blobs for GetRequests with Include_All and Include_Deleted_Blobs

Open
#868 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
1.8k
Forks
298
Avg merge
21h 43m
Merged PRs (30d)
9

Description

GetRequests with Include_All and Include_Deleted_Blobs will return blobs from storage node even if they are deleted irrespective they are hard deleted or not. But from a customer standpoint, returning a hard-deleted blob is not useful and we don't we give any intimation on this regards. So, would like to have a fix wherein, Router/StorageNode should not return hard deleted blobs for GetRequests with Include_All and Include_Deleted_Blobs

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace GetRequests through the Router and StorageNode paths, focusing on the Include_All and Include_Deleted_Blobs handling and how hard-deleted blobs are represented. First identify the request filtering and storage lookup entry points, then add or update coverage for hard-deleted blobs. Done means these requests no longer return hard-deleted blobs while the intended handling of other deleted blobs remains intact.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
distributed-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.