linkedin / linkedin/ambry

Make Cluster Manager correctly recognize newly added nodes

Open
#819 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement newbie
Dominant language
Java
Stars
1.8k
Forks
298
Avg merge
21h 43m
Merged PRs (30d)
9

Description

Helix based cluster manager does not dynamically recognize newly added nodes. It assumes that `InstanceConfig` change notifications come in only for nodes that it already knows of. When such notifications come in for newly added nodes, the cluster manager meets with a NPE, because it tries to dereference the return value from the hash map of existing nodes (which it expects to always return a non-null value).

At a high level, the way to handle this within `onInstanceConfigNotification()` is to look up the instance in question in the hash map, and if it is absent, then add it as a new entry in much the same way as instance additions are done during initialization.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Cluster Manager implementation and its onInstanceConfigNotification() handler, then compare its handling of known instances with instance additions during initialization. Reproduce the notification for a newly added node and verify that the node is added without a null dereference and is subsequently recognized by the manager.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
distributed-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.