linkedin / linkedin/ambry

Fix or add Index and BlobStore tests with SystemTime rather than MockTime of 0

Open
#596 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Java
Stars
1.8k
Forks
298
Avg merge
21h 43m
Merged PRs (30d)
9

Description

Most of the tests in Index and BlobStore are using a MockTime and uses 0 as it initial value. So, chances are that integer overflow may not be caught with such tests when SystemTime is used. Would be good to initialize the MockTime to SystemTime.currentTimeInmillis() so that we can mimic the real system.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the tests for Index and BlobStore and inspect how MockTime is initialized. Compare those setups with SystemTime.currentTimeInmillis(), then update or add coverage so time-dependent integer overflow behavior is exercised with a realistic starting time.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
distributed-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.