Remove appendFrom(ByteBuffer) method in the Write interface
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 298
- Avg merge
- 21h 43m
- Merged PRs (30d)
- 9
Description
It is used only in tests and tests can easily use the method that takes in a channel. This avoids duplicated code in the implementations (also there isn't a production use case for this function).
Remove the functions from the implementations also.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search for the Write interface and every implementation of appendFrom(ByteBuffer), then inspect the tests that use the ByteBuffer overload. Confirm that tests can use the channel-based method, remove the overload from the interface and implementations, and run the relevant test suite to verify the remaining write behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100