linkedin / linkedin/ambry

Modify ByteBufferReadableStreamChannel to take in a list of ByteBuffer

Open
#394 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement newbie
Dominant language
Java
Stars
1.8k
Forks
298
Avg merge
21h 43m
Merged PRs (30d)
9

Description

The current constructor of ByteBufferReadableStreamChannel takes in a single ByteBuffer.

public ByteBufferReadableStreamChannel(ByteBuffer buffer);

This functionality can be expanded by adding another constructor that takes in a List of ByteBuffer.

public ByteBufferReadableStreamChannel(List<ByteBuffer> buffers);

(The first constructor would call into the second constructor to avoid duplicate code).

This would help support more use cases.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the ByteBufferReadableStreamChannel constructors and inspect the existing implementation and tests for current behavior. Add support for a List while preserving the single-buffer constructor behavior, then run the relevant test suite to verify the new constructor handles the requested list use case.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.