Fix misbehaving tests
Open
Nobody has claimed this yet.
bug
newbie
- Dominant language
- Java
- Stars
- 1.8k
- Forks
- 298
- Avg merge
- 21h 43m
- Merged PRs (30d)
- 9
Description
(Edits by @vgkholla to delete tests that are no longer relevant)
The following tests were failing intermittently or hanging and were commented out in PR #294. This ticket tracks their fixes.
In BlockingChannelConnectionPoolTest:
- testBlockingChannelInfoForPlainText (fails intermittently)
com.github.ambry.network.BlockingChannelConnectionPoolTest > testBlockingChannelInfoForPlainText FAILED
java.lang.AssertionError at BlockingChannelConnectionPoolTest.java:242
- testSSLBlockingChannelConnectionPool (fails intermittently)
com.github.ambry.network.BlockingChannelConnectionPoolTest > testSSLBlockingChannelConnectionPool FAILED
java.lang.Exception at BlockingChannelConnectionPoolTest.java:396
In SimpleByteBufferPoolTest:
- testOneExpiredAnotherServed (hangs intermittently, seemingly deadlocked)
one thread:
at java.lang.Thread.join(Thread.java:1354)
at com.github.ambry.utils.SimpleByteBufferPoolTest.testOneExpiredAnotherServed(SimpleByteBufferPoolTest.java:220)
another thread:
at java.util.concurrent.CountDownLatch.await(CountDownLatch.java:236)
at com.github.ambry.utils.SimpleByteBufferPoolTest$BufferConsumer.run(SimpleByteBufferPoolTest.java:259)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the three named tests in BlockingChannelConnectionPoolTest and SimpleByteBufferPoolTest, along with PR #294 where they were commented out. Reproduce the intermittent assertion, exception, and deadlock, then verify that all three tests run reliably and pass without hanging.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- distributed-systems, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100