linkedin / linkedin/LiTr

VideoFilterPreviewView rotation only rotate the view, not content

Open
#149 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
663
Forks
92
PR merge metrics
No merged PRs in 30d

Description

Hi, I'm currently trying to apply rotation to video preview together with filter preview. I apply it by using `android:rotation` to the `com.linkedin.android.litr.preview.VideoFilterPreviewView`. I've tried this within `litr-demo:VideoFilterPreviewFragment`.
but the video content being played is not rotated, instead it is stretched weirdly based on rotated view area. How can I correctly rotate the content for the VideoFilterpreview?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting com.linkedin.android.litr.preview.VideoFilterPreviewView and the rotation usage in litr-demo:VideoFilterPreviewFragment. Reproduce the behavior with android:rotation and trace how the preview content is laid out. Done means the video content rotates with the view without being stretched; no specific test is mentioned in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
audio-video-rtc, mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.