linkedin / linkedin/LiTr

Completion never hit

Open
#118 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Java
Stars
663
Forks
92
PR merge metrics
No merged PRs in 30d

Description

I have been using this library for a month-ish now (it's 🔥🚒).

I recently found a bug where video trimming never completes. The progress reaches around 0.999874 and then the completion / error / cancel callbacks are not called.

My suspicion is that this is just an arithmetic error. To get around this I wrapped the callback in a suspending cancelable coroutine, and give the coroutine a timeout. Unfortunately that means I consider 0.9999848 a failure, but I imagine under the hood it actually succeeded.

Would be nice to fix this (:

Contributor guide

Open the contributing guide

Research direction

No file, test, or entry point is named. Start by reproducing video trimming with progress near 0.999874 and trace the completion, error, and cancel callback paths; done means one of the expected callbacks is reliably invoked when trimming finishes.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, java
Domain
audio-video-rtc, mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.