linkedin / linkedin/Burrow

Groups Reaper functionality no longer deletes prometheus metrics

Open
#758 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
4k
Forks
818
Avg merge
1h 14m
Merged PRs (30d)
1

Description

https://github.com/linkedin/Burrow/commit/718a013595569e9da196ebd4d09f7c4e7d27eeb9 commit reverted the change which deleted metrics from expired consumer groups.

Metrics are currently preserved and served up for expired consumer groups (those which are not listed under the /consumer route).

@bai I'm unsure why that change needed to be reverted?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review commit 718a013595569e9da196ebd4d09f7c4e7d27eeb9 and trace the Groups Reaper path that handles expired consumer groups. Confirm how Prometheus metrics are currently retained and verify that completed behavior removes metrics for groups no longer listed under the /consumer route.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kafka, prometheus
Domain
observability
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.