linkedin / linkedin/Burrow

API exposes both `current_lag` and `current-lag` in different places

Open
#618 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Go
Stars
4k
Forks
818
Avg merge
1h 14m
Merged PRs (30d)
1

Description

This was quite confusing:

- `current-lag`: https://github.com/linkedin/Burrow/blob/1f807c463a568f62e1b168bada587f31b2006ba7/core/protocol/storage.go#L165
- `current_lag`: https://github.com/linkedin/Burrow/blob/0ba4b22398b30c7ba8231ed622a9280ae1f3551d/core/protocol/evaluator.go#L61

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare the `current-lag` field in `core/protocol/storage.go` at the linked revision with `current_lag` in `core/protocol/evaluator.go` at its linked revision. Determine the consistent API spelling expected across these protocol responses, then update the affected definition or use and verify that both places expose the same name.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.