Correctly set Host on HTTP notifiers
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 4k
- Forks
- 818
- Avg merge
- 1h 14m
- Merged PRs (30d)
- 1
Description
Hi,
According to https://github.com/golang/go/issues/29865, the Host header is ignored is should be set instead using req.Host
Burrow currently supports setting HTTP headers on for the notifiers. It needs a small change for the particular case of the header Host
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Go HTTP notifier implementation and its existing HTTP-header handling. Check the referenced Go behavior for Host, then verify that a configured Host value is applied through the request's host handling and that the notifier still sends other configured headers correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100