Notifiers using empty CA pool if no extra CA file is specified
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 4k
- Forks
- 818
- Avg merge
- 1h 14m
- Merged PRs (30d)
- 1
Description
https://github.com/linkedin/Burrow/blob/a449cc412c48231a2b7347cd790f82b8ed18faf2/core/internal/notifier/helpers.go#L124
Ran into this today. I'm not 100% familiar with Go, so maybe I'm missing something, but this function seems as though it never, under any circumstances, loads the system certificate pool. Instead, it creates an empty CA pool, and (optionally) adds a specified extra certificate to it.
In our case, this led to Burrow being unable to connect to any SSL sites if verification was on or if we didn't specify a path to a PEM file containing root CAs.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at core/internal/notifier/helpers.go around line 124 and inspect how the certificate pool is created when no extra CA file is configured. Verify the notifier can connect to SSL sites with certificate verification enabled without a PEM path; that behavior is done when existing notifier tests or a focused reproduction confirm system roots are available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 62/100