linkedin / linkedin/Burrow

Support configuration of other SASL mechanisms

Open
#526 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
4k
Forks
818
Avg merge
1h 14m
Merged PRs (30d)
1

Description

Currently, there is no way to configure the SASL mechanism in a SASL Profile. So it defaults to PLAIN

Looks like we simply need to set the mechanism here based on configuration: https://github.com/linkedin/Burrow/blob/master/core/internal/helpers/sarama.go#L114

Then we will be able to support the following SASL Mechanisms https://github.com/Shopify/sarama/blob/master/broker.go#L55

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in core/internal/helpers/sarama.go around line 114, then read the SASL mechanism definitions referenced in Sarama's broker.go around line 55. Trace how a SASL Profile is configured and determine how the configured mechanism should replace the current PLAIN default; the work is done when supported mechanisms can be selected through configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kafka
Domain
authentication, security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.