linkedin / linkedin/Burrow

Burrow 1.0 RC configuration for a large amount of email addresses? address+consumer_group@domain.com

Open
#274 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
4k
Forks
818
Avg merge
1h 14m
Merged PRs (30d)
1

Description

In pre 1.0 I could create an email notifier that included the consumer_group in the address like.

`email+consumer_group@domain.com` I can still do this but:

A lot of configuration is repeated. SMTP information feels like it could be constant and would be nice to just reference in an [smtp.name1] section and just refer to in a notifier though. Some psuedo-code:

`for consumer_group in consumer_groups:`
```
[notifier.email_{{ consumer_group }}]
class-name="email"
extras={key="value", key2="value2"}
interval=300
group-whitelist='*'
threshold=1
template-open="{{ burrow.email.template }}"
template-close="{{ burrow.email.template }}"
send-close=true
server={{ burrow.email.server }}
port={{ burrow.email.port }}
auth-type=plain
username={{ burrow.email.username }}
from="burrow-beta-noreply@domain.com"
to="me+{{ consumer_group }} @domain"
password={{ burrow.email.password }}
```
`end for`

Something like this, or along the same lines, (I'm not married to this config line for line). For instnace, maybe even the template, threshold, send-close, and extras could be moved into their own sections and merged with a notifier section?
```
[smtp.config1]
server={{ burrow.email.server }}
port={{ burrow.email.port }}
auth-type=plain
username={{ burrow.email.username }}
from="burrow-beta-noreply@domain.com"
to="me+{{ consumer_group }}@domain"
password={{ burrow.email.password }}
```
`for consumer_group in consumer_groups:`
```
[notifier.email_{{ consumer_group }}]
class-name="email"
extras={key="value", key2="value2"}
interval=300
group-whitelist="*"
threshold=1
template-open="{{ burrow.email.template }}"
template-close="{{ burrow.email.template }}"
send-close=true
smtp="smtp.config1"

```
`end for`

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing Burrow's existing email notifier and configuration handling. Compare the current notifier settings with the proposed reusable SMTP section and per-consumer-group address expansion; done should be defined as an agreed configuration design that avoids repeated SMTP and notifier settings.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.