linebender / linebender/vello

Make the Apple emoji hack more specific to Apple

Open
#982 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
4.3k
Forks
300
Avg merge
2d 13h
Merged PRs (30d)
61

Description

We have a hack for the y offset of Apple emoji, see e.g. #981. However, this hack could be incorrectly applied to another font.

I do think this check should look at the name table as it risks applying an incorrect offset to other sbix fonts - Chad

Thus we should add additional checks to make sure we only target the fonts we know for sure need it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Apple emoji y-offset hack described in issue #981 and inspect where its font checks are implemented. Determine which name-table checks identify the known Apple fonts, then verify that the offset is no longer applied to unrelated sbix fonts.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
computer-graphics
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.