linebender / linebender/vello

`vello_shaders` build.rs does not fail if shaders fail to compile

Open
#962 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
4.3k
Forks
300
Avg merge
2d 13h
Merged PRs (30d)
61

Description

If naga fails, it just emits warning and uses old shaders. I think it should panic on naga error and thus stop compilation.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the vello_shaders build.rs entry point and inspect how naga shader-compilation errors are handled. Run the shader build or relevant compilation check; done means a naga failure stops compilation instead of emitting a warning and reusing old shaders.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.