linebender / linebender/vello

Enforcing formatting in tests everywhere

Open
#946 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
4.3k
Forks
300
Avg merge
2d 13h
Merged PRs (30d)
61

Description

See https://github.com/linebender/vello/pull/945. Formatting is not currently enforced everywhere, as `cargo fmt --all` does not pick up all files.

We could do the following in CI, but perhaps someone knows of a better way.

```bash
cargo fmt --check -- ./**/*.rs
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing PR #945 and the CI configuration that currently runs formatting checks. Run the proposed cargo fmt --check -- ./**/*.rs command and compare its coverage with cargo fmt --all. Done means CI reliably checks formatting for all relevant Rust files.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
ci-cd
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.