vello_common: Flood filter implementation maybe not entirely correct
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 4.3k
- Forks
- 300
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 61
Description
If i'm not mistaken, our current flood filter implementation works by getting the bounding box (in wide tile units!) of all drawn objects on the layer and then flooding those with the color. This means that if we have a small 3x3 rectangle, we will still fill 256 pixels of the whole width of a wide tile, which is probably incorrect.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the flood filter implementation in vello_common and inspect how it derives the layer's bounding box in wide tile units. Reproduce the reported small 3x3 rectangle case and compare the flooded area with the actual drawn bounds. Done means the filter no longer fills the whole wide tile when the content occupies only a small region.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100